fix: catch up chat messages missed while the event stream was down#419
Open
raulriera wants to merge 1 commit into
Open
fix: catch up chat messages missed while the event stream was down#419raulriera wants to merge 1 commit into
raulriera wants to merge 1 commit into
Conversation
The DM event stream is a cursorless live push and the server never replays, so messages delivered while it was dropped were silently lost until the user left and re-entered the chat. EventStreamer now surfaces its connection state; ConversationController treats the first live connection as the baseline and refetches the feed plus the open transcript on each reconnect after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While you sit in a chat, new messages from the other person sometimes stopped appearing. The live message connection can't replay anything it missed, so whenever it briefly dropped — a network blip, switching between Wi-Fi and cellular, or coming back from the background — every message that arrived during the gap was silently lost until you left and reopened the chat. The app now notices when the connection comes back and refetches the conversation list plus the open chat to fill in whatever it missed, while skipping that work on the very first connection so there's no wasted fetch on open.
Test plan